]> dgit.raspbian.org Git - gnome-shell.git/commit
folderView: Reset schemas before removing the folder
authorGeorges Basile Stavracas Neto <georges.stavracas@gmail.com>
Thu, 21 Nov 2019 21:45:12 +0000 (18:45 -0300)
committerGeorges Basile Stavracas Neto <georges.stavracas@gmail.com>
Thu, 21 Nov 2019 22:28:46 +0000 (22:28 +0000)
commitbd173ac5d243f097f56728e897809451d1735735
treea647737d4cadb109ebedb4c77924b908249e75d2
parentbfc7c1cd65eee4872aeff837a77f7c6e33aae0ef
folderView: Reset schemas before removing the folder

When removing the last icon of a folder, FolderView first removes
the folder from org.gnome.desktop.app-folders.folder-children, then
proceeds to reset all its keys, which removes the relocatable schema.

That order of operations turns out to be problematic. Removing the
folder from 'folder-children' destroys the folder icon, which in turn
destroys the folder view, which throws a load of warnings in the
journal.

Fix that by removing the folder after resetting the schema keys. In
fact, what we're doing here is not using 'this' anymore.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/841
js/ui/appDisplay.js